Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-7886: Use astropy rather than pyfits #13

Merged
merged 7 commits into from Jul 11, 2018
Merged

DM-7886: Use astropy rather than pyfits #13

merged 7 commits into from Jul 11, 2018

Conversation

timj
Copy link
Member

@timj timj commented Jul 9, 2018

No description provided.

@timj timj requested a review from r-owen July 9, 2018 22:57
r-owen
r-owen approved these changes Jul 10, 2018
View reviewed changes
Copy link
Contributor

@r-owen r-owen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However, please consider fixing pep8 errors at the same time, especially replacing file with open in makeWarpedNoiseCoadd.py and warpAndCoadd.py. Also consider enabling automatic flake8 checking.

@timj timj merged commit 2115a9e into master Jul 11, 2018
@ktlim ktlim deleted the tickets/DM-7886-coadd_chisquared branch August 25, 2018 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r-owen r-owen r-owen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timj @r-owen