DM-9190: Cleanup pybind11 remaining code #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschella
force-pushed
the
tickets/DM-9190
branch
2 times, most recently
from
c27a480
to
2848a55
Compare
r-owen
requested changes
Mar 27, 2017
| @@ -68,7 +68,7 @@ def addExposure(self, exposure, weightFactor=1.0): | |||
| filter = exposure.getFilter() | |||
| self._filterDict.setdefault(filter.getName(), filter) | |||
|
|
|||
| overlapBBox = chisquaredLib.addToCoadd(self._coadd.getMaskedImage(), self._weightMap, | |||
| overlapBBox = addToCoadd(self._coadd.getMaskedImage(), self._weightMap, | |||
| exposure.getMaskedImage(), self._badPixelMask, weightFactor) | |||
There was a problem hiding this comment.
Picky, but please consider running autopep8 or at least fixing this indent.
| PYBIND11_PLUGIN(_addToCoadd) { | ||
| py::module mod("_addToCoadd", "Python wrapper for _addToCoadd library"); | ||
| PYBIND11_PLUGIN(addToCoadd) { | ||
| py::module mod("addToCoadd"); |
There was a problem hiding this comment.
Both afw.geom and afw.image need to be imported.
pschella
force-pushed
the
tickets/DM-9190
branch
from
2848a55
to
6394516
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.