Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-1350: General cleanup of Events package #1

Merged
merged 21 commits into from
Mar 31, 2015
Merged

Commits on Feb 25, 2015

  1. Configuration menu
    Copy the full SHA
    2e5afc1 View commit details
    Browse the repository at this point in the history
  2. Remove references to pex_policy and PipelineLogEvent

    Change copyright notices to new standard copyright
    srp3rd committed Feb 25, 2015
    2 Configuration menu
    Copy the full SHA
    4c2cc69 View commit details
    Browse the repository at this point in the history
  3. Added ability to specify filterable keywords.

    Event (and their subclasses) carry certain standard keywords in message headers that are filterable server-side, when used in conjunction with selectors.   The rest of the property set information is kept in the payload of the message, and is not filterable with selectors.
    
    This change allows the user to add keywords and values that will be added into the message header, so they can be filtered server-side as well.
    srp3rd committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    037139a View commit details
    Browse the repository at this point in the history
  4. Removed creation and deconstruction of OriginatorIDs from EventSystem.

    Added Host and LocationID objects.
    Changed references from OriginatorID value to LocationID objects in CommandEvent and StatusEvent.
    Added references to Host and Location in eventsLib.i, and removed PipelineLogEvent.h
    Added unit tests for Host and LocationID
    
    further notes about this change:
    
    CommandEvent - Remove old references to OriginatorID.  These are replaced
    with hostname and local id; these are used in conjunction with process id
    to achieve the same purpose as OriginatorID, while fixing the issue of
    the OriginatorID having a localID value that can potentially churn too
    quickly.
    
    The process ID in OriginatorID was originally 16-bits, but this broken on
    Mac because it can have a larger than 16-bit pid.  This was temporarily
    changed to 17-bits (to get a build running), and is now 32-bit with this
    change.  Hostname was used to make it more user-friendly.  OriginatorID
    could be addressed as one value before in an event selector; this can
    still be achieved by using hostname, ipid, and localid together.  These
    values can be retrieved together in a LocationID object.
    srp3rd committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    533103a View commit details
    Browse the repository at this point in the history
  5. Changed to new copyright notices. Removed vestiges of policy.

    Note that LogEvent.h is going to be change to depend on log instead
    of pex_logging in the near future.
    srp3rd committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    17f6acf View commit details
    Browse the repository at this point in the history
  6. These tests where all changed to use the unit test framework, which

    wasn’t being used when this package was originally written. Nearly
    all the tests were renamed to better describe what was being tested. In
    tests where Policy was being used, those tests were removed.  Note that
    nearly all these tests depend on sending messages to the central
    activemq broker.
    srp3rd committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    9b3dcc3 View commit details
    Browse the repository at this point in the history
  7. Fixed all the examples, which were very out of date. Removed referenc…

    …es to policy.
    
    Note that current references to pex_logging will change to the new log package in the near future.
    srp3rd committed Feb 25, 2015
    Configuration menu
    Copy the full SHA
    cefff1e View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2015

  1. Fixed an issue where removing pex_policy's swig include also removed …

    …a typemap that
    
    mapped a vector of std::string to list;  without it, it gets returned as a tuple.  Added
    the correct typemap so this mapping is performed.
    srp3rd committed Feb 26, 2015
    Configuration menu
    Copy the full SHA
    772942c View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2015

  1. 1. Changed variable names to be more descriptive in examples/receiveL…

    …og.py
    
    2. Moved locations of "const" as per LSST C++ style guide and changed
        const PropertySet::Ptr to CONST_PTR(PropertySet).
    3. Removed unused variable in EventFactory.cc
    4. Added base to get CONST_PTR declaration.
    srp3rd committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    d6c984a View commit details
    Browse the repository at this point in the history
  2. 1. Change "const" as per LSST C++ style guide in Event object

    2. Change LocationID returns for CommandEvent methods to return shared pointers
    3. Change tests/CommandEvent.py tests to tests against created object's local id.
    4. Fix line lengths over 110.
    srp3rd committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    d033b01 View commit details
    Browse the repository at this point in the history
  3. 1. Remove unneeded headers from Host.h

    2. Remove constructor/deconstructor and add const to methods in Host.h
    3. Remove commented out code, and fix iterators in Events.cc
    4. Remove code that created pointers and immediately dereferenced them.
    5. Add braces to two line if statements.
    srp3rd committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    53cefe2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7833a5b View commit details
    Browse the repository at this point in the history
  5. remove _constructor() & deconstructor and consolidate code in Locatio…

    …nID.cc
    
    Remove unnecessary includes, namespace and using from Host.cc
    Use system constant HOST_NAME_MAX in place of 255.
    srp3rd committed Mar 10, 2015
    Configuration menu
    Copy the full SHA
    166f5a4 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2015

  1. Configuration menu
    Copy the full SHA
    0cbb988 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2015

  1. Removed obsolete method

    srp3rd committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    e9a5267 View commit details
    Browse the repository at this point in the history
  2. Throw exception instead of returning empty string

    syntactic clean up for boolean
    srp3rd committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    a688274 View commit details
    Browse the repository at this point in the history
  3. Modified tests to include memory allocation checker

    (didn't include EventLogging.py in that because it's going away real soon now)
    Removed packages that weren't necessary in .cfg file
    srp3rd committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    7af9f38 View commit details
    Browse the repository at this point in the history
  4. use assertRaises() instead of trapping exception for validity

    minor C++ style fixes (ie, add spaces)
    srp3rd committed Mar 25, 2015
    Configuration menu
    Copy the full SHA
    b74b839 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2015

  1. Clean up test cases

    srp3rd committed Mar 26, 2015
    Configuration menu
    Copy the full SHA
    0df9e3a View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2015

  1. To prevent build failures where the unit tests can't reach the broker,

    fixed the tests so that they run in the specified domain (ncsa) and are
    otherwise skipped.
    srp3rd committed Mar 27, 2015
    Configuration menu
    Copy the full SHA
    452f709 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2015

  1. Moved all header comments to .h files.

    Some of these (the logging ones) weren't done, because they're going to
    be removed and replaced soon.
    srp3rd committed Mar 31, 2015
    Configuration menu
    Copy the full SHA
    727d9bf View commit details
    Browse the repository at this point in the history