DM-5292: Add queue support #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed loops, at request. Added code to remove raw pointers being passed back.
Refactored EventTransmitter and EventReceiver to create new base classes Transmitter and Receiver. These are used to build EventTransmitter, EventReceiver, EventEnqueuer, and EventDequeuer. Fixed raw pointers being passed back from existing methods. Removed unnessary #includes and whitespace at the end of lines.
assertIsNotNone and assertIsNone, respectively. Changed assertEqual when comparing a list to assertTupleEqual. Fixed direct assert inequality to None comparision to assertIsNotNone
…broker can be contacted.
| @@ -42,7 +42,8 @@ | |||
| #include <iostream> | |||
| #include <set> | |||
|
|
|||
| #include "lsst/utils/Utils.h" | |||
| #include "boost/shared_ptr.hpp" | |||
There was a problem hiding this comment.
Can we group the boost includes together?
#include files.
Removed unused #include files Fixed doxygen comments Changed duplicate strings to use one reference
| * @brief get the destination property name | ||
| * @note This is the TYPE of the destination we're using, either a TOPIC or a QUEUE | ||
| */ | ||
| virtual std::string getDestinationPropertyName() { return NULL; } |
There was a problem hiding this comment.
Sorry, I realize it's too late for comments, but I still have to say it 😄
I hope this method is never called (overridden in all subclasses), constructing an std::string from zero pointer will very likely result in a crash. If you want an empty string use "" or explicit std::string() (I prefer latter).
There was a problem hiding this comment.
Good catch. I suggest you file a ticket so it can get fixed.
There was a problem hiding this comment.
OK, done, DM-7009 assigned to @srp3rd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.