use shell builtin command instead of which
#11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
reviewed
Apr 6, 2018
| @@ -18,7 +18,7 @@ module add gcc/4.4.5 | |||
|
|
|||
| echo ${HERE} | |||
|
|
|||
| which gcc | |||
| command -v gcc | |||
There was a problem hiding this comment.
This is just telling the user what compiler is in the path??? Maybe in that case type -a gcc would be more informative?
There was a problem hiding this comment.
I assumed the intent was to document the actual compiler used.
There was a problem hiding this comment.
Sure, but this seems clearer:
$ type -a clang
clang is /usr/bin/clang
than
$ command -v clang
/usr/bin/clang
jhoblitt
force-pushed
the
tickets/DM-14026-which
branch
from
d5f6342
to
f349836
Compare
|
I'm going to go ahead and merge this since it is trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.