Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed remnants of pex_policy #13

Merged
merged 3 commits into from Sep 18, 2018
Merged

Removed remnants of pex_policy #13

merged 3 commits into from Sep 18, 2018

Conversation

srp3rd
Copy link
Contributor

@srp3rd srp3rd commented Sep 17, 2018

removed:

killcondor.py - used the old style pex_policy job description to identify and kill jobs.
writeNodeList.py - this was required in an early version of ctrl_orca to enumerate the nodes used (in pbs jobs, I believe).
ProvenanceRecorder.py - This was used to make database records for policy files used in a run. This was in addition to the provenance information that used to be recorded via the provenance package, which is also obsolete, since it also used pex_policy. I don't think a replacement was ever made for that package.

lsst/ctrl/orca/PolicyUtils.py - used to get all file names listed in a policy

Deleted line from ups/ctrl_orca.table, since pex_policy, is no longer required.

Removed "-r" option from bin.src/orca.py which referred to policy directory. This was an obsolete option.

removed:

killcondor.py - used the old style pex_policy job description to identify and kill jobs.
writeNodeList.py - this was required in an early version of ctrl_orca to enumerate the nodes used (in pbs jobs, I believe).
ProvenanceRecorder.py - This was used to make database records for policy files used in a run.  This was in addition to the provenance information that used to be recorded via the provenance package, which is also obsolete, since it also used pex_policy.  I don't think a replacement was ever made for that package.

lsst/ctrl/orca/PolicyUtils.py - used to get all file names listed in a policy

Deleted line from ups/ctrl_orca.table, since pex_policy, is no longer required.

Removed "-r" option from bin.src/orca.py which referred to policy directory. This was an obsolete option.
@hsinfang
Copy link

Not really related to this PR, but it came up when I tried to use this ticket that eups cannot find the optional packages condor and condor_glidein. I don't see such packages at github.com/lsst or lsst-dm either. Any ideas what they are? Are they still needed?

…lts that way throughout the rest of

the code.  If we decide to use Config files repositories later, this can easily be re-added.
@srp3rd
Copy link
Contributor Author

srp3rd commented Sep 18, 2018

Not really related to this PR, but it came up when I tried to use this ticket that eups cannot find the optional packages condor and condor_glidein. I don't see such packages at github.com/lsst or lsst-dm either. Any ideas what they are? Are they still needed?

One of the reasons we left it as optional when I asked K-T how to handle this (conversation was many years ago) was to indicate it has an external Condor dependency. Since only this is only used by NCSA on NCSA computers, we didn’t think having it as optional would be a big deal. I removed it.

Copy link

@hsinfang hsinfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srp3rd srp3rd merged commit 2315192 into master Sep 18, 2018
@srp3rd srp3rd deleted the tickets/DM-15771 branch September 18, 2018 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants