DM-10430: Add time stamps to the console logs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulPrice
approved these changes
May 2, 2017
| @@ -2,7 +2,7 @@ log4j.rootLogger=INFO, A1, F1 | |||
| log4j.appender.A1=ConsoleAppender | |||
| log4j.appender.A1.Target=System.err | |||
| log4j.appender.A1.layout=PatternLayout | |||
| log4j.appender.A1.layout.ConversionPattern=%X{PID} %-5p %c: %m%n | |||
| log4j.appender.A1.layout.ConversionPattern=%X{PID} %-5p %d{yyyy-MM-ddThh:mm:ss.sss} %c: %m%n | |||
There was a problem hiding this comment.
This looks reasonable.
What timezone is used? If UTC, you should add a Z at the end of the time format.
There was a problem hiding this comment.
They would be the same time zone as the machines. Would that be fine?
There was a problem hiding this comment.
I would really like the timezone to be logged in all cases. Can you add a "Z" (which is a date formatter character, and only coincidentally becomes a UTC indicator) to the end of this?
There was a problem hiding this comment.
Opened #16
I assume we don't need another ticket?
There was a problem hiding this comment.
#16 has been approved and merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.