DM-13614: SlurmBatch: fix --time for large walltime #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python/lsst/ctrl/pool/parallel.py
Outdated
| @@ -216,6 +216,22 @@ def submitCommand(self, scriptName): | |||
| class SlurmBatch(Batch): | |||
| """Batch submission with Slurm""" | |||
|
|
|||
| @staticmethod | |||
| def formatWalltime(walltime): | |||
| """Format walltime as days-hours:minutes""" | |||
There was a problem hiding this comment.
If not documenting in numpy docstring style, at least change to the following, so that people can see that walltime is in seconds without having to read the code:
"""Format walltime (in seconds) as days-hours:minutes"""
Now format walltime as days-hours:minutes instead of just minutes.
PaulPrice
force-pushed
the
tickets/DM-13614
branch
from
af6b72f
to
53cf898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now format walltime as days-hours:minutes instead of just minutes.