Comm: add alternate version of scatter #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default version apparently pickles the entire 'dataList', which can cause errors if the pickle size grows over 2^31 bytes due to fundamental problems with pickle in python 2 [1][2] (causing, e.g., "OverflowError: integer 2155421250 does not fit in 'int'"). Instead, we send the data to each slave node in turn; this reduces the pickle size. [1] http://bugs.python.org/issue11564 [2] https://www.python.org/dev/peps/pep-3154/
n8pease
commented
Oct 20, 2016
| @param root Index of root node | ||
| @param tag Message tag (integer) | ||
| @return Data for this node | ||
| """ |
There was a problem hiding this comment.
You might consider using numpy style documentation here.
There was a problem hiding this comment.
I would, but I think using the old style is preferred to using heterogeneous styles in the same file, and also preferred to investing time in updating the entire file to use numpydoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default version apparently pickles the entire 'dataList', which
can cause errors if the pickle size grows over 2^31 bytes due to
fundamental problems with pickle in python 2 [1][2](causing, e.g.,). Instead,
we send the data to each slave node in turn; this reduces the pickle
size.
[1] http://bugs.python.org/issue11564
[2] https://www.python.org/dev/peps/pep-3154/