Tickets/dm 2701 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added code to Persistence_2.py in tests/ that will simply exit without running any tests if the user does not have credentials for the necessary database added code to the C++ unit tests to exit without failing if the user does not have credentials to access the test database added comments explaining changes to unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit tests were failing if the user had a .lsst/db-auth.paf file without the correct credentials. This is because unit tests were skipped based on whether or not .lsst/db-auth.paf existed, without regards to its contents. This skip was implemented in the tests/SConscript file. This pull requests moves the skipping determination into the actual unit tests themselves, and makes the decision whether or not to skip a test based on both the contents and the existence of .lsst/db-auth.paf.