Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-16550: Fix race condition in YAML test #105

Merged
merged 3 commits into from Nov 26, 2018
Merged

DM-16550: Fix race condition in YAML test #105

merged 3 commits into from Nov 26, 2018

Conversation

timj
Copy link
Member

@timj timj commented Nov 20, 2018

No description provided.

Without this the temp directory was being ignored and the
files were written to the root directory.
Rather than using special code locally for comparing PropertySet
and PropertyList.
Otherwise foo/ directory is created in root.
@timj timj requested a review from ktlim November 20, 2018 19:19
Copy link
Contributor

@ktlim ktlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timj timj merged commit 7649090 into master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants