DM-18488: Support pyyaml 5.1 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
force-pushed
the
tickets/DM-18488-daf_persistence
branch
2 times, most recently
from
e401be6
to
eabc803
Compare
ktlim
approved these changes
Mar 21, 2019
| @@ -193,7 +193,11 @@ class ButlerLocation(yaml.YAMLObject): | |||
| """ | |||
|
|
|||
| yaml_tag = u"!ButlerLocation" | |||
| yaml_loader = yaml.Loader | |||
| try: | |||
There was a problem hiding this comment.
Is this actually used anywhere? It seems strange that this is a class variable rather than built into from_yaml, and I don't see any caller for the latter or use of the variable.
There was a problem hiding this comment.
This class inherits from yaml.YamlObject and yaml_loader is the class variable that yaml assumes will define the loader.
timj
force-pushed
the
tickets/DM-18488-daf_persistence
branch
from
eabc803
to
d838d25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.