DM-12594: Remove daf::base::Citizen #111
Conversation
| } | ||
| { authPolicy = pexPolicy::Policy::Ptr(new pexPolicy::Policy(filename)); } |
There was a problem hiding this comment.
Why is this happening in its own execution block?
There was a problem hiding this comment.
Ha! Look at the diff above: this was just collapsed by clang-format from lines 89-94 in the original.
So, I have no idea why it's a separate block.
There was a problem hiding this comment.
I think I vaguely recall either Jim or Pim working on something to to with the scopeGaurd. I think it was related to a ticket Pim had worked on to make daf persistence thread safe, which is what the scope had to be in place. Now that that is removed I think the scope block can be removed too.
There was a problem hiding this comment.
You may be right about the reasoning, but according to git history, the scopeGuard was added 10 years ago by smm.
I'm tempted to just leave it as is, given the imminent removal of daf_persistence. ;-)
No description provided.