DM-28659: Change 1000 to 3 writers in test. #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parejkoj
reviewed
Feb 5, 2021
| """Test for efficient file updating with shared & exclusive locks by serializing a RepositoryCfg to a | ||
| location 1000 times. When this was tested on a 2.8 GHz Intel Core i7 macbook pro it took about 1.3 seconds | ||
| to run. When the squash performance monitoring framework is done, this test could be monitored in that | ||
| system.""" | ||
|
|
||
| def setUp(self): | ||
| self.testDir = tempfile.mkdtemp(dir=ROOT, prefix='TestOneThousandWriters-') | ||
| self.testDir = tempfile.mkdtemp(dir=ROOT, prefix='TestMultipleWriters-') |
There was a problem hiding this comment.
Why not do f{"self.__class__.__name__}-" for the prefix here, to keep it generic?
There was a problem hiding this comment.
Seems a bit too fancy for something that is scheduled to die before the end of the year.
parejkoj
reviewed
Feb 6, 2021
| @@ -167,28 +167,12 @@ def writeCfg(cfg, go): | |||
| dp.PosixStorage.putRepositoryCfg(cfg) | |||
|
|
|||
| def testWriteCfg(self): | |||
tests/test_safeFileIo.py
Outdated
| @@ -147,14 +147,14 @@ def testNoChange(self): | |||
| self.assertEqual(f.read(), "some test string") | |||
|
|
|||
|
|
|||
| class TestOneThousandWriters(unittest.TestCase): | |||
| class TestMultipleWriters(unittest.TestCase): | |||
| """Test for efficient file updating with shared & exclusive locks by serializing a RepositoryCfg to a | |||
| location 1000 times. When this was tested on a 2.8 GHz Intel Core i7 macbook pro it took about 1.3 seconds | |||
There was a problem hiding this comment.
This is no longer 1000 times. Please update the docstring if anything else needs to change, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.