DM-29497: Issue deprecation warning for Mapper/Butler #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktlim
approved these changes
Mar 30, 2021
| import traceback | ||
| import warnings | ||
|
|
||
| ALWAYS = None |
There was a problem hiding this comment.
I thought all-caps items were supposed to be constants. Should have a docstring; I believe the valid values are None, False, True?
There was a problem hiding this comment.
Oh, I get it, despite its use in the test, it is supposed to be a hard-coded constant, right?
There was a problem hiding this comment.
Yes, I'm not sure how we want to play it. I was leaving the ALWAYS=True option for when we need to get serious about removing things. I'm fine with making it a public variable.
This allows subclasses to issue the warning even if they don't call __init__ of base class.
This only works for the base classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code implements three options:
I've defaulted it to only one ever for now.