Enable reading polymorphic pex_config types (DM-32062) #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-slac
force-pushed
the
tickets/DM-32062
branch
from
6d2f5c6
to
d72d293
Compare
ktlim
reviewed
Oct 6, 2021
ktlim
approved these changes
Oct 6, 2021
The `readConfigStorage()` method now uses special Config method which can read arbitrary types from serialized data. We still limit allowed types to the sub-classes of the type defined in policy.
andy-slac
force-pushed
the
tickets/DM-32062
branch
from
d72d293
to
b59a25e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
readConfigStorage()method now uses special Config method whichcan read arbitrary types from serialized data. We still limit allowed
types to the sub-classes of the type defined in policy.