-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-7069: Port to Python 3 #19
Commits on Jul 29, 2016
-
Configuration menu - View commit details
-
Copy full SHA for f7cf7c1 - Browse repository at this point
Copy the full SHA f7cf7c1View commit details
Commits on Aug 6, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 5c44b7b - Browse repository at this point
Copy the full SHA 5c44b7bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c80f098 - Browse repository at this point
Copy the full SHA c80f098View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee0a38e - Browse repository at this point
Copy the full SHA ee0a38eView commit details
Commits on Aug 9, 2016
-
With some manual tweaks where futurize doesn't quite do the right thing. ReadProxy can not inherit from future object as this breaks the proxy on Python 2.
Configuration menu - View commit details
-
Copy full SHA for 9b5a6a5 - Browse repository at this point
Copy the full SHA 9b5a6a5View commit details -
Switch pyfits to astropy.io.fits
The interfaces are compatible so this just changes the namespace.
Configuration menu - View commit details
-
Copy full SHA for 1d1e088 - Browse repository at this point
Copy the full SHA 1d1e088View commit details -
On Python 3 str has __iter__ so all the tests that are checking for an iterable in the codebase have to also be careful not to include str by mistake. Refactor the code that looks for __iter__ to use routines from utils where possible. Where not possible add instance checks for string.
Configuration menu - View commit details
-
Copy full SHA for b345d21 - Browse repository at this point
Copy the full SHA b345d21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86a44d7 - Browse repository at this point
Copy the full SHA 86a44d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37908b7 - Browse repository at this point
Copy the full SHA 37908b7View commit details -
Determine root directory from test file
Use __file__ to find the test file and then derive repository locations from it.
Configuration menu - View commit details
-
Copy full SHA for c7bb6a7 - Browse repository at this point
Copy the full SHA c7bb6a7View commit details -
Catch TypeError from getargspec
Future object does not have an __init__ method so we have to catch that case in the MRO.
Configuration menu - View commit details
-
Copy full SHA for 8ce08a5 - Browse repository at this point
Copy the full SHA 8ce08a5View commit details -
Explcitly try UserDict variants
Python 3 collections.UserDict is iterable but not on Python 2. Python 2 requires we use UserDict.IterableUserDict so try that first and then revert to collections.
Configuration menu - View commit details
-
Copy full SHA for ba08c09 - Browse repository at this point
Copy the full SHA ba08c09View commit details -
Mark expected test failures as expected test failures
This allows the tests to be visible to the test runner and is better than globally disabling all testing in the file and hiding the tests.
Configuration menu - View commit details
-
Copy full SHA for 5827082 - Browse repository at this point
Copy the full SHA 5827082View commit details -
Configuration menu - View commit details
-
Copy full SHA for c7a3e96 - Browse repository at this point
Copy the full SHA c7a3e96View commit details -
Use str type for filter not bytes, and compare int not type(1)
Futurize converted types.StringType to bytes (technically correct on python2) when it should have converted to str.
Configuration menu - View commit details
-
Copy full SHA for fbc523c - Browse repository at this point
Copy the full SHA fbc523cView commit details -
DbStorage class is not iterable
The next() method is just a method that iterates but is not providing an iterable interface allowing the next() function to work.
Configuration menu - View commit details
-
Copy full SHA for bd6bbd2 - Browse repository at this point
Copy the full SHA bd6bbd2View commit details -
Fix pytest warnings about class names
pytest assumes that classes with names starting with Test are test classes that should be analyzed for test methods. When it can't find any it warns that something might be wrong. Rename the tests to remove the warnings.
Configuration menu - View commit details
-
Copy full SHA for e629340 - Browse repository at this point
Copy the full SHA e629340View commit details -
Configuration menu - View commit details
-
Copy full SHA for def6809 - Browse repository at this point
Copy the full SHA def6809View commit details