make Policy init via duck typing #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.assertRaises(IOError, Policy, filePath="c:/policy.yaml") | ||
| self.assertRaises(IOError, Policy, filePath="c:/policy.paf") | ||
| self.assertRaises(IOError, Policy, filePath="c:/policy") | ||
| self.assertRaises(IOError, Policy, "c:/policy.yaml") |
There was a problem hiding this comment.
Can you rewrite these using with so it's clearer what the test is.
There was a problem hiding this comment.
It's a shame FileNotFoundError seems to be Python 3 only.
n8pease
force-pushed
the
tickets/DM-7255
branch
4 times, most recently
from
a11c087
to
a720368
Compare
| self.assertRaises(IOError, Policy, filePath="c:/policy.paf") | ||
| self.assertRaises(IOError, Policy, filePath="c:/policy") | ||
| # Test that loading paf & yaml files that do not exist raises an IOError. | ||
| self.assertRaises(IOError, Policy, "c:/nonExistantPath/policy.yaml") |
There was a problem hiding this comment.
Please use
with self.assertRaises(IOError):
Policy("c:....yaml")as it is much clearer how the command is constructed that triggers the exception.
removes kwarg style input arguments
n8pease
force-pushed
the
tickets/DM-7255
branch
from
217fc34
to
1a4a8c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes kwarg style input arguments