Tickets/dm 7719 #29
Tickets/dm 7719 #29
Conversation
|
I'm still checking these. @TallJimbo has checked the unit tests. I'll add a reviewer for the code when I'm ready. |
| components[0] = location.componentInfo[components[0]].datasetType | ||
| # join components back into a dot-delimited string | ||
| datasetType = '.'.join(components) | ||
| location = self._locate(datasetType, dataId, write) |
There was a problem hiding this comment.
I don't think this recursion does what you want, since only components[0] is ever modified. That also suggests that you may need to do a test of a datasetType like "foo.bar.baz". Also, what if the component datasetType contains one or more dots?
There was a problem hiding this comment.
Oops. Never mind about the first part, I missed the components = components[1:] above. And I think the second part might also not be an issue.
| # enforce dataId & repository tags when reading: | ||
| if not write and dataId.tag and len(dataId.tag.intersection(repoData.tags)) == 0: | ||
| continue | ||
| components = datasetType.split('.') |
There was a problem hiding this comment.
The name components is a little confusing since it's also the term you use for the dict of components of the composite, whereas this is a list of dotted parts of the datasetType.
n8pease
force-pushed
the
tickets/DM-7719
branch
from
ce0ab30
to
7cc3a86
Compare
No description provided.