DM-9918: Robustify sqlite use #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8pease
reviewed
Apr 22, 2017
| if haveSqlite3 and re.match(r'.*\.sqlite3', location): | ||
| if re.match(r'.*\.sqlite3', location): | ||
| if not haveSqlite3: | ||
| raise RuntimeError("sqlite3 registry specified (%s), but unable to import sqlite3 module" % |
There was a problem hiding this comment.
this line looks longer than 80 chars (is that rule official yet?) and are we preferring .format to % string substitution now?
There was a problem hiding this comment.
On both points I have followed the current style in that file.
If we're given a sqlite3 registry, then the user expects us to use it. But if we failed to import the sqlite3 module then there's nothing we can do so we should raise an exception.
It doesn't make sense for the PosixRegistry to be a file.
PaulPrice
force-pushed
the
tickets/DM-9918
branch
from
c20d59a
to
e4f6c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.