DM-10267: Port HSC support for PostgreSQL registries to LSST #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8pease
reviewed
May 9, 2017
|
|
||
| class PgsqlRegistry(SqlRegistry): | ||
| """A PostgreSQL-based registry""" | ||
| placeHolder = "%s" |
There was a problem hiding this comment.
It seems like it would make sense to move placeHolder = "?" from line 291 to the SqliteRegistry subclass. If you wanted to get really fancy about it, I think it would make sense to make SqlRegistry an abc, and create an abstract method placeholder that subclasses would then be forced to implement.
n8pease
reviewed
May 9, 2017
| ---------- | ||
| location : `str` | ||
| Path to PostgreSQL configuration file. | ||
| """ |
There was a problem hiding this comment.
init method documentation is supposed to go in the class docstring I think.
PaulPrice
force-pushed
the
tickets/DM-10267
branch
from
3c4fa8f
to
7705d1c
Compare
This will allow us to easily add different flavors of SQL-based registries.
A filename ending in ".pgsql" indicates the use of PostgreSQL. That file should be in YAML format and contain entries to specify the use of a pgsql database.
PaulPrice
force-pushed
the
tickets/DM-10267
branch
from
7705d1c
to
b0628d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.