daf_persistence - convert mapperArgs to dict if it is None #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennywlo
reviewed
Jul 28, 2017
| """ | ||
| def test(self): | ||
| cfg = dp.RepositoryCfg(root='foo', mapper='foo', mapperArgs=None, parents=None, policy=None) | ||
| self.assertIsInstance(cfg.mapperArgs, dict) |
There was a problem hiding this comment.
Missing _ for referencing mapperArgs.
There was a problem hiding this comment.
it's confusing from this diff; _mapperArgs is a private parameter, accessed by a property mapperArgs, which is not shown here. I discussed this with Kenny & got the sign-off.
n8pease
force-pushed
the
tickets/DM-11289
branch
from
d788362
to
c63d2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.