DM-11664: Flake8 fixes #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8pease
reviewed
Aug 28, 2017
| self.dataId, | ||
| self.mapper, | ||
| self.componentInfo, | ||
| self.repository) | ||
|
|
||
| def __repr__(self): | ||
| return "ComponentInfo(datasetType=%s, obj=%s, setter=%s, getter=%s)" % ( | ||
| self.datasetType, self.obj, self.setter, self.getter) |
There was a problem hiding this comment.
this is the definition to remove.
There was a problem hiding this comment.
I think there's another one at line 146...
Retain the one that had the most detailed information.
timj
commented
Aug 28, 2017
| return "ComponentInfo(datasetType=%s, obj=%s, setter=%s, getter=%s)" % ( | ||
| self.datasetType, self.obj, self.setter, self.getter) | ||
|
|
||
| return 'ButlerComposite(assembler:%s, disassembler:%s, python:%s, dataId:%s, mapper:%s, ' \ |
There was a problem hiding this comment.
Of the three, I kept this one as it looked the most detailed.
…test For some tests we are testing that the constructor runs without error but not using the return value from the constructor. This fails flake8 so this change adds tests for the return values to ensure they are of the expected type.
timj
commented
Aug 28, 2017
| self.assertTrue(os.path.exists(os.path.join(self.testDir, 'repositoryCfg.yaml'))) | ||
|
|
||
| butler2 = dp.Butler(inputs=uri) |
There was a problem hiding this comment.
I removed this since it seemed to be the same call as the next one but not protected by a try block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.