DM-11771: Add destructor to close sqlite connection #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timj
approved these changes
Sep 1, 2017
timj
changed the title
note that for __del__ to get called the garbage collector must be triggered after the final reference has been released. in unit tests this may be done in tearDown by calling gc.collect. If we find having or closing the open database connection is a problem in production code, we may need to add api to butler to explicity release database connections (and maybe other things like in-memory cached objects).
n8pease
force-pushed
the
tickets/DM-11771
branch
from
0a90a64
to
1e3f45f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.