Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-11885: look in daf_persistence for python2-style calls to super() and replace with python 3 style calls. #80

Merged
merged 2 commits into from Sep 15, 2017
Merged

DM-11885: look in daf_persistence for python2-style calls to super() and replace with python 3 style calls. #80

merged 2 commits into from Sep 15, 2017

Conversation

n8pease
Copy link
Contributor

@n8pease n8pease commented Sep 14, 2017

No description provided.

@timj
Copy link
Member

timj commented Sep 14, 2017

I think you need to add

from builtins import super

to each file to allow this to work on python2?

@timj timj changed the title tickets/DM-11885 look in daf_persistence for python2-style calls to super() and replace with python 3 style calls. DM-11885: look in daf_persistence for python2-style calls to super() and replace with python 3 style calls. Sep 14, 2017
@n8pease
Copy link
Contributor Author

n8pease commented Sep 14, 2017

I've added from builtins import super, but accidentally pushed most of it straight to master: I had done rebuild lsst_apps in my py2 env so I could test it and forgot that it checked out master to do that and failed to notice that daf_persistence was no longer on the ticket branch. The commit is ee03f11

timj
timj approved these changes Sep 14, 2017
View reviewed changes
Copy link
Member

@timj timj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me now.

@timj
Copy link
Member

timj commented Sep 14, 2017

Can you fix the commit message of 01765e6 so it doesn't trail off?

@n8pease
Copy link
Contributor Author

n8pease commented Sep 14, 2017

oh, hah. weird. yup, will do.

@n8pease n8pease merged commit 632aadd into master Sep 15, 2017
@ktlim ktlim deleted the tickets/DM-11885 branch August 25, 2018 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timj timj timj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@n8pease @timj