DM-10319: _filename functions return first mappable repository even when file does not exist #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For debugging purposes it is often useful to know the location in the file tree where the butler will fetch a particular dataset, including parents. This is intended to give more information than the _filename magic, and can return the read or write location.
n8pease
reviewed
Mar 12, 2018
tests/test_repository.py
Outdated
| @@ -10,7 +10,7 @@ | |||
| # This program is free software: you can redistribute it and/or modify | |||
| # it under the terms of the GNU General Public License as published by | |||
| # the Free Software Foundation, either version 3 of the License, or | |||
| # (at your option) any later version. | |||
| # (at your option) any later version.1n | |||
There was a problem hiding this comment.
I think this 1n is a typo?
erykoff
force-pushed
the
tickets/DM-10319
branch
from
0d0f6e2
to
6ef571c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on JIRA, this implementation sidesteps the _filename magic entirely and adds a new getUri(write=write) method for debugging that retrieves the actual filename that the butler will use. This is what developers expect.