Catch only NoResults and IOError exceptions. #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bypass function handling was trapping all exceptions, but most of them are actually errors that should be reported.
n8pease
reviewed
Mar 15, 2018
| if hasattr(location.mapper, "bypass_" + location.datasetType): | ||
| bypass = self._getBypassFunc(location, dataId) | ||
| try: | ||
| bypass = bypass() | ||
| location.bypass = bypass | ||
| except Exception: | ||
| except (NoResults, IOError): |
There was a problem hiding this comment.
Maybe it would be helpful to log something here? "a bypass function exists but no file was found at {location}" ??
I don't know/up to you, I've just been seeing a lot of asks for helpful error messages in recent threads. OTOH it might be noisy in the logs...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bypass function handling was trapping all exceptions, but most of them are actually errors that should be reported.