DM-14356: Add matplotlib.figure.Figure storage to PosixStorage. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
May 9, 2018
| Raises | ||
| ------ | ||
| ValueError | ||
| Raised if the file |
There was a problem hiding this comment.
Trailing sentence. I also don't see a raise below.
There was a problem hiding this comment.
I just removed the whole section; I don't know what I was thinking.
| # default. | ||
| ext = None | ||
| obj.savefig(logLoc.locString(), format=ext) | ||
| return |
There was a problem hiding this comment.
Is the return meant to be indented to within the with SafeFilename here?
There was a problem hiding this comment.
The empty return here serves no purpose, and should be removed.
There was a problem hiding this comment.
Yup, this is a copy-paste relic. I'll go remove the returns I cargo-culted too.
wmwv
reviewed
May 25, 2018
| logLoc = LogicalLocation(locationString, additionalData) | ||
| # SafeFilename appends a random suffix, which corrupts the extension | ||
| # matplotlib uses to guess the file format. | ||
| # Instead, we strip off the extension from the original location |
There was a problem hiding this comment.
I would say "extract the extension".
"strip off the extension" implies it's removed from the location name.
TallJimbo
force-pushed
the
tickets/DM-14356
branch
from
ed2a3cd
to
95eedcb
Compare
Matplotlib figures cannot be retrieved using the butler, but 'put' should now work. Note that this storage actually only requires that the object being saved have a `savefig` method with the same behavior as matplotlib's.
TallJimbo
force-pushed
the
tickets/DM-14356
branch
from
95eedcb
to
37986b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matplotlib figures cannot be retrieved using the butler, but 'put' should now work.
Note that this storage actually only requires that the object being saved have a
savefigmethod with the same behavior as matplotlib's.