DM-15599: Stop using boost persistence in afw #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
changed the title
r-owen
force-pushed
the
tickets/DM-15599
branch
from
f24ce70
to
5157cad
Compare
r-owen
changed the title
r-owen
force-pushed
the
tickets/DM-15599
branch
2 times, most recently
from
33ebe81
to
803378f
Compare
Simplify FITS I/O for "FitsStorage" by calling new methods readFitsWithOptions or writeFitsWithOptions on those objects. instead of using boost persistence.
r-owen
force-pushed
the
tickets/DM-15599
branch
from
803378f
to
c7c5b9a
Compare
TallJimbo
requested changes
Sep 10, 2018
|
|
||
|
|
||
| def boostReadFitsStorage(butlerLocation): | ||
| """Read a FITS image from a butlerLocation using boost peristence |
There was a problem hiding this comment.
Seems like we should remove this function and check that we don't actually use it anywhere anymore.
I also don't think it actually makes sense - we've never used Boost to read FITS code. At most this could be using Boost to read daf::base::Persistable, but that has nothing to do with FITS.
There was a problem hiding this comment.
Sounds great! I will try that and see what Jenkins thinks.
There was a problem hiding this comment.
You were right. After removing this Jenkins still ran, including ci_hsc! Please have another look. I plan to leave removal of the "BoostStorage" entry in the posix registry as a second commit because feels like an separate step from changing how the "FitsStorage" entry works.
TallJimbo
approved these changes
Sep 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.