Initial TAP-like implementation. #6
Conversation
brianv0
force-pushed
the
tickets/DM-5318
branch
from
e07c096
to
c8fb3e5
Compare
VOTable-like json VOTable XML output through template Refactor Field Helper code Use engineFactory
brianv0
force-pushed
the
tickets/DM-5318
branch
from
c8fb3e5
to
377b358
Compare
| def getDb(): | ||
| '''Lists supported versions for /db.''' | ||
| @app.route('/') | ||
| def application_root(): |
There was a problem hiding this comment.
With all of these function name changes (getRoot -> application_root, etc.) I don't see any changes to the client code as part of this ticket. Are there any users of this service yet?
There was a problem hiding this comment.
Actually the function names are inconsequential, I was just trying to do some PEP8 cleanup. The reason why they are inconsequential is because the decorator above the name, @app.route, registers the function at import time to the Flask framework. The Flask framework handles incoming HTTP requests, finds out routes match (/db in this case), and dispatches to the method. So Flask, in effect, is the only client to these methods and it doesn't really care about the method name (except for debugging purposes)
However, the HTTP route did, in fact, change. SUI is the main consumer of the HTTP interface and they've been notified. The routes changed to more closely adhere to the guidelines in the TAP interface.
VOTable-like json
VOTable XML output through template
Refactor Field Helper code