tickets/DM-2299 #5
Conversation
| This module is a wrapper around MySQLdb. It contains a set of low level basic | ||
| database utilities such as connecting to database. It caches connections, and | ||
| handles database errors. | ||
| This module wraps SQLAlchemy. |
There was a problem hiding this comment.
This is a confusing statement. We do not wrap whole sqlalchemy here, only one method which instantiates engine.
| str(e.orig.args[0]), e.orig.args[1]) | ||
|
|
||
| #### Loading sql script ############################################################ | ||
| def loadSqlScript(scriptPath, **kwargs): |
There was a problem hiding this comment.
I think we should get rid of this method entirely, I don't think we use it anywhere and it's kind of problematic code.
There was a problem hiding this comment.
We use it in dax_metaserv (admittedly in tests only) and in cat (admittedly that code is very rusty and needs a refresh, most will be replaced by the new metaserv)
jbecla
force-pushed
the
tickets/DM-2299
branch
3 times, most recently
from
e56f38c
to
ec0839f
Compare
| if fileName.startswith('~'): | ||
| fileName = os.path.expanduser(fileName) | ||
| if not os.path.isfile(fileName): | ||
| raise IOError |
There was a problem hiding this comment.
Needs some arguments like ("File %s does not exist" % fileName), but I would leave that check to ConfigParser.
There was a problem hiding this comment.
I did leave it to the ConfigParser first, but it throws "NoSectionError: No section: 'database'" which I found too misleading.
There was a problem hiding this comment.
Ok, according to the docs parser.read() is used to load optional files, so it does not throw an exception when file is missing, but instead returns the list of files that were loaded. SO I think we should replace parser.read(fileName) with:
parser.readfp(open(fileName), fileName)
and this should take care of the missing file (I think this is better than os.path.isfile() because there may be case when file exists but it's not readable)
jbecla
force-pushed
the
tickets/DM-2299
branch
from
ec0839f
to
3141603
Compare
| This module contains small utilities / helpers that perform common tasks related to | ||
| the Db wrapper. | ||
|
|
||
| This module contains utilities / helpers that perform common tasks, in particular these that are specific to different drivers. |
jbecla
force-pushed
the
tickets/DM-2299
branch
from
3d2374d
to
8b971b3
Compare
jbecla
force-pushed
the
tickets/DM-2299
branch
from
900bb87
to
e306f14
Compare
Revisit whether we need something better than a very basic db connection pool.