Remove dependency on mysqldb in wmgr (DM-3947) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbecla
force-pushed
the
tickets/DM-3947
branch
from
9595059
to
ff391e6
Compare
|
|
||
|
|
||
| #### Unclassified functions ######################################################## | ||
| def typeCode2Name(conn, code): |
There was a problem hiding this comment.
This has portability issues, I believe code above is not a portable sqlalchemy thing. As I mentioned in qserv branch this is closely related to what Brian wants to do for dax_dbserv, maybe we should merge this together with Brian's development.
There was a problem hiding this comment.
@brianv0 , how would you like to proceed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.