Fix for utils.listDbs() method (DM-4204) #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -95,6 +95,8 @@ def getEngineFromFile(fileName, | |||
| url.port = port | |||
| if database: | |||
| url.database = database | |||
| if query: | |||
| url.query = query | |||
There was a problem hiding this comment.
should we add "or query" to the if on line 84?
There was a problem hiding this comment.
Yes, good point, I missed that. I'll add it there.
Tested with wmgr and works OK now. Additional small cleanup for pylint-exposed issues.
andy-slac
force-pushed
the
tickets/DM-4204
branch
from
b3015b8
to
323dafa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with wmgr and works OK now. Additional small cleanup for
pylint-exposed issues.