Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DM-18036: Switch to HTM reference #29

Merged
merged 2 commits into from Oct 30, 2019
Merged

DM-18036: Switch to HTM reference #29

merged 2 commits into from Oct 30, 2019

Conversation

SimonKrughoff
Copy link
Contributor

No description provided.

@timj
Copy link
Member

timj commented Oct 30, 2019

Can you add a .gitattributes file to declare that the FITS files are binaries?

@SimonKrughoff
Copy link
Contributor Author

You mean you want me to put them in git-lfs?

@timj
Copy link
Member

timj commented Oct 30, 2019

No. I mean to create a .gitattributes file.

@timj
Copy link
Member

timj commented Oct 30, 2019

See e.g. https://github.com/lsst/daf_butler/blob/master/.gitattributes

@SimonKrughoff SimonKrughoff changed the title Switch to HTM reference DM-18036: Switch to HTM reference Oct 30, 2019
erykoff
erykoff approved these changes Oct 30, 2019
View reviewed changes
Copy link

@erykoff erykoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@SimonKrughoff SimonKrughoff merged commit 6c39fe4 into master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erykoff erykoff erykoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SimonKrughoff @timj @erykoff