Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26471: README for lsst_dm_stack_demo is incorrect #37

Merged
merged 1 commit into from Oct 7, 2020

Conversation

jdswinbank
Copy link
Contributor

No description provided.

@@ -35,7 +35,7 @@ output; choose a result set appropriate for your system. The ./bin/compare
script can then be used to check if your results are within the expected
numerical tolerances::

$ python bin/compare.py detected-sources.txt
$ ./bin/compare detected-sources.txt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm wondering how this works with SIP on macOS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it?

Copy link
Member

@timj timj Oct 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in a meeting so I can't test your new invocation just now. The previous version should be fine (dropping the .py though and using bin.src....). I guess adding LSST_LIBRARY_PATH to compare would also work.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I'm an idiot. Compare doesn't use any LSST code so it has nothing to import so SIP is not a problem. Sorry for the noise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, you're doing better than me — it didn't even occur to me that SIP might be a problem until you pointed it out, and then I didn't realise it wouldn't be... until you pointed it out. One of those days...!

@jdswinbank jdswinbank merged commit 984f8e4 into master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants