-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update upstream to mariadb 10.2.14 #14
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,35 +13,17 @@ config() | |
# TokuDB requires third-party software jemalloci (see http://www.canonware.com/jemalloc/) | ||
ARGS+=('-DPLUGIN_TOKUDB=NO') | ||
|
||
# Always use bundled PCRE | ||
# Due to cmake library discovery being overly energetic (searching every | ||
# lib directory relative to each entry in $PATH) we use the bundled ZLIB and | ||
# PCRE libraries to avoid link confusion downstream | ||
ARGS+=('-DWITH_ZLIB=bundled') | ||
ARGS+=('-DWITH_PCRE=bundled') | ||
|
||
# Prevent CMake from finding and linking against libraries distributed in $(dirname | ||
# python)/../lib. This is CMake's default behaviour, but can cause us to erroneously link | ||
# python)/../lib. This is CMake's default behavior, but can cause us to erroneously link | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Really? English spelling is not acceptable to you? 😛 |
||
# against libraries distributed by e.g. Anaconda. | ||
PYTHONLIBDIR=$(which python | sed -e's|bin/python|lib|') | ||
ARGS+=("-DCMAKE_SYSTEM_IGNORE_PATH=${PYTHONLIBDIR}") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I have the same question here as on lsst-dm/legacy-mariadbclient#12 |
||
|
||
case $(uname) in | ||
Linux*) | ||
if grep -q -i "CentOS release 5" /etc/redhat-release; then | ||
# mroonga does not build on EL5 (conda ref platform) and is | ||
# unused by LSST | ||
ARGS+=('-DPLUGIN_MROONGA=NO') | ||
# required to build on EL5 | ||
ARGS+=('-DHAVE_CXX_NEW=NO') | ||
fi | ||
;; | ||
Darwin*) | ||
# Disable external SSL on OS X as it is not a standard library | ||
# and LSST does not need full SSL support. | ||
ARGS+=('-DWITH_SSL=bundled') | ||
;; | ||
*) | ||
# non-fatal | ||
echo "unsupported platform: $(uname)" | ||
;; | ||
esac | ||
|
||
cmake . "${ARGS[@]}" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit message isn't really clear about this ZLIB change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. It was part of "Streamline eupspkg.cfg to be more similar with mariadbclient version", but it certainly wouldn't hurt to be more explicit; will fix.
Still losing on OSX, BTW :-/ For some reason, -DWITH_SSL=off doesn't seem to bypass the failing GnuTLS check, though it seems by my first reading of the cmake file that it should. Installing GnuTLS via homebrew "fixes" it, but I don't think we want to add another prereq if we can avoid it. I'll continue to fiddle with it...