DM-8828: Support proper motions in reference catalogs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-owen
force-pushed
the
tickets/DM-8828
branch
from
4c58a2a
to
8d2e43b
Compare
r-owen
force-pushed
the
tickets/DM-8828
branch
from
8d2e43b
to
56206d2
Compare
loadSkyCircle now takes an 'epoch' argument, intended for proper motion corrections. However, our astrometry.net catalogs don't typically support proper motion correction, and even when they do the format of the data isn't certain, so no proper motion correction is done here.
r-owen
force-pushed
the
tickets/DM-8828
branch
from
56206d2
to
303c347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadSkyCircle now takes an 'epoch' argument, intended for proper motion
corrections. However, our astrometry.net catalogs don't typically
support proper motion correction, and even when they do the format
of the data isn't certain, so no proper motion correction is done here.