DM-12882: Use compression-safe method for getting calexp dimensions. #23
Conversation
TallJimbo
force-pushed
the
tickets/DM-12882
branch
from
b4e5a09
to
dcccc1f
Compare
| catalog = mosaicUtils.rotatePixelCoordsBack(catalog, calexp_md.get("NAXIS1"), | ||
| calexp_md.get("NAXIS2"), nQuarter) | ||
| catalog = mosaicUtils.rotatePixelCoordsBack(catalog, dimensions.getX(), | ||
| dimensions.getY(), nQuarter) |
There was a problem hiding this comment.
I realize this code violates linting all over the place, but can you do anything to make sure it won't complain about dimensions possibly not being defined here? If it's too expensive to always get dimensions even if it's not needed, then you could set it to None before the first if nQuarter%4...
There was a problem hiding this comment.
I ran a linter on this file and found one real error which I will ask you to fix while you're in here: TaskError is not defined. Please add it to the items imported form lsst.pipe.base at line 26.
There was a problem hiding this comment.
The function getFluxFitParams gets wcsHeader but does not use it. I suggest deleting the two lines that get it. I suspect this may be leftover
There was a problem hiding this comment.
The function getWcs reads metadata and then uses it to construct a WCS. Would it work to read the WCS directly?:
if hscRun is not None:
wcsName = "wcs_hsc"
else:
wcsName = "wcs"
return dataRef.get(wcsName, immediate=True)
There was a problem hiding this comment.
Unfortunately the wcs dataset is actually an Exposure dataset, so at best we could do dataRef.get("wcs").getWcs() - but I think even that doesn't work because it's a zero-size Exposure.
We should make it actually a Wcs (or soon, SkyWcs) persisted directly with FitsCatalogStorage (DM-11138). I think that'll have to be backwards incompatible, however, and I haven't had the free energy to RFC that and push it through.
No description provided.