DM-11138: Add jointcal_ prefixes to wcs and photoCalib datasets. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
reviewed
Feb 22, 2018
| try: | ||
| return dataRef.get("jointcal_wcs") | ||
| except NoResults: | ||
| return dataRef.get("wcs").getWcs() |
There was a problem hiding this comment.
Worth noting that this is for compatibility with old datasets?
TallJimbo
force-pushed
the
tickets/DM-11138
branch
2 times, most recently
from
fa8a0f3
to
701ba38
Compare
fcr is left unchanged; it's already semi-deprecated in favor of photoCalib (now jointcal_photoCalib). The test and display code that uses old outputs committed to this repository has also been left unchanged, aside from an update to make sure the backwards-compatibility fallbacks work.
TallJimbo
force-pushed
the
tickets/DM-11138
branch
from
701ba38
to
5087e4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fcr is left unchanged; it's already semi-deprecated in favor of photoCalib (now jointcal_photoCalib).
The test and display code that uses old outputs committed to this repository has also been left unchanged.