DM-14997: Implement RFC-498: homogenize naming of calibration flags #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenam
force-pushed
the
tickets/DM-14997
branch
2 times, most recently
from
08afa27
to
84ed122
Compare
This implements RFC-498 and includes: - calib_psfUsed -> calib_psf_used - calib_psfCandidate -> calib_psf_candidate - calib_astrometryUsed -> calib_astrometry_used to match the other exsiting flags: - calib_photometry_used - calib_photometry_reserved and to match the recently updated documentation in afw/doc/table.dox, in particular: "if the prefix of a field name represents a conceptual group of multiple fields, use underscores to join the group name to the group elements."
laurenam
force-pushed
the
tickets/DM-14997
branch
from
84ed122
to
185795a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements RFC-498 and includes:
to match the other exsiting flags:
and to match the recently updated documentation in afw/doc/table.dox, in
particular: "if the prefix of a field name represents a conceptual group
of multiple fields, use underscores to join the group name to the group
elements."