DM-10156: Replace all uses of Calib with PhotoCalib #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I didn't change all `calib`-related names, since there's a lot of stuff backed in to meas_mosaic an the test files that would then break.
The updated colorterm code can do most of the work itself, and it will handle the units more correctly.
parejkoj
force-pushed
the
tickets/DM-10156
branch
from
cd56b03
to
2fb35f4
Compare
yalsayyad
reviewed
Apr 4, 2019
| refMag, refMagErr = self.cterm.getCorrectedMagnitudes(refCat, | ||
| afwImage.Filter(calexp_md).getName()) | ||
| # NOTE: mosaic assumes fluxes are in Jy | ||
| refFlux = (refMag*astropy.units.ABmag).to_value(astropy.units.Jy) |
There was a problem hiding this comment.
This is a weird mix of astropy to compute the refFlux and the stack to compute refFluxErr.
Does afwImage.fluxFromABMag work?
There was a problem hiding this comment.
I'm trying to get rid of all uses of that in the stack prior to deprecation. See DM-16903.
Unfortunately, astropy doesn't currently have a way to handle the error calculations directly (astropy.uncertainty isn't finished yet), otherwise I would have replaced the other one too.
yalsayyad
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.