DM-19015: Fix reading fcr photoCalib #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fcr object is an empty Exposure, which now contains a PhotoCalib object, persisted directly (instead of having Calib headers FLUXMAG0/FLUXMAG0ERR), so we get the fcr_photoCalib, instead of reading the metadata. This should also maintain backwards compatibility with old files. Update the dataRef mock in test_fluxFitBoundedField to be able to return an fcr_photoCalib (which is a valid composite object for a real butler).
parejkoj
force-pushed
the
tickets/DM-19015
branch
from
017c2bf
to
cb5be57
Compare
hsinfang
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.