DM-9887: Wrap meas_mosaic with pybind11 instead of swig #6
Conversation
pschella
force-pushed
the
tickets/DM-9887
branch
from
ab065ce
to
6fd90e8
Compare
python/lsst/meas/mosaic/__init__.py
Outdated
| # see <https://www.lsstcorp.org/LegalNotices/>. | ||
| #/ | ||
|
|
||
| """lsst...meas.mosaic |
There was a problem hiding this comment.
Extra dots? Unnecessary docstring.
python/lsst/meas/mosaic/chebyshev.cc
Outdated
| cls.def_readwrite("coeffs", &Chev::coeffs); | ||
|
|
||
| return mod.ptr(); | ||
| } |
There was a problem hiding this comment.
I don't think this header needs to be wrapped at all - I don't see it in the %includes in mosaicLib.i.
python/lsst/meas/mosaic/fluxfit.cc
Outdated
| cls.def_readwrite("xorder", &FluxFitParams::xorder, py::return_value_policy::copy); | ||
| cls.def_readwrite("yorder", &FluxFitParams::yorder, py::return_value_policy::copy); | ||
| cls.def_readwrite("absolute", &FluxFitParams::absolute); | ||
| cls.def_readwrite("coeff", &FluxFitParams::coeff, py::return_value_policy::copy); |
There was a problem hiding this comment.
xorder, yorder, and coeff seem to be used as arrays, so I'm not sure this wrapping will work for those. I'm fairly confident those could never be used from Python and it's probably best just to not wrap them at all.
| cls.def_readwrite("order", &Class::order); | ||
| cls.def_readwrite("ncoeff", &Class::ncoeff); | ||
| cls.def_readwrite("xorder", &Class::xorder, py::return_value_policy::copy); | ||
| cls.def_readwrite("yorder", &Class::yorder, py::return_value_policy::copy); |
There was a problem hiding this comment.
As with the xorder and yorder attributes on FluxFitParams, these should not be wrapped, as they'll only cause trouble in Python.
| cls.def_readwrite("a", &Class::a, py::return_value_policy::copy); | ||
| cls.def_readwrite("b", &Class::b, py::return_value_policy::copy); | ||
| cls.def_readwrite("ap", &Class::ap, py::return_value_policy::copy); | ||
| cls.def_readwrite("bp", &Class::bp, py::return_value_policy::copy); |
There was a problem hiding this comment.
These pointers are used as arrays and should not be accessible in Python.
pschella
force-pushed
the
tickets/DM-9887
branch
from
7c4fd91
to
9ed07f1
Compare
pschella
force-pushed
the
tickets/DM-9887
branch
from
4337c09
to
636b0e5
Compare
No description provided.