DM-9862: attempt to properly rotate meas_mosaic outputs #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this rotation, the wcs is output in the meas_mosaic coords (LLC w.r.t. FP is 0,0) as opposed to the LSST coords (0,0 attached to the electronics, so 0,0 is the associated with the LLC of ampifier 1). This makes use of the new rotateWcsPixelsBy90() function in meas_astrom, which properly rotates a TAN-SIP wcs, to rotate the new wcs to the LSST coordinate system prior to persisting. Note that the fcr files are still being persisted in the HSC coordinate system. This is accounted for in updateExposure.py and is safe (as of now) since no other code uses these files.
This includes the pybind11 wrapping which no longer exposes the getElementCount() function on keys and the change in the persistence file locations of the meas_mosaic outputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempt is known to be incomplete, but the remainder of the work is already on another ticket.