Limit MACOSX_DEPLOYMENT_TARGET based on Python. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not possible to compile Python extensions targeting an earlier SDK than Python itself was compiled for. Conversely, we don't want to target a later version of the SDK than is available on the current platform. Finally, the stack itself requires at least OSX 10.9. Here, we attempt to be smart about choosing an SDK version that satisfies all the above constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not possible to compile Python extensions targeting an earlier SDK than
Python itself was compiled for. Conversely, we don't want to target a later
version of the SDK than is available on the current platform. Finally, the
stack itself requires at least OSX 10.9.
Here, we attempt to be smart about choosing an SDK version that satisfies all
the above constraints.