DM-14728: Add asEigenArray/Matrix returning Eigen::Map #14
Conversation
r-owen
force-pushed
the
tickets/DM-14728
branch
2 times, most recently
from
a5b32a4
to
7c800ec
Compare
There was a problem hiding this comment.
Ah, this reminds me why I had done the pybind11 suffix fix via a patch here: I assumed LSST was probably the only consumer of ndarray that couldn't just upgrade to pybind11 2.2.x to fix this problem, and hence the only consumer that would want this rather unportable, hacky fix. I think that's probably the right reasoning, so I think I may do a quick revert of that commit in ndarray, add a note to the README about pybind11 versions, push out 1.5.1, and then have you restore this patch.
|
ndarray 1.5.1 is out, without the pybind11 2.1.x suffix fix. |
|
Can you update the CHANGELOG to say SWIG support is removed as well? |
Already done. |
Include free functions `asEigen`, `asEigenArray` and `asEigenMatrix`. This version of ndarray also allows building without EigenView, for compatibility with Eigen 3.3. But switching to that is left for another ticket, as it will require some changes to our pybind11 wrappers.
|
I have updated to 1.5.1 and restored the patch. It builds on my Mac and I'm about to start another Jenkins run. Please have another look. For future reference: please consider removing the .gitignore file when making the tarball; due to a bug in lsstsw rebuild it ends up replacing the original. |
I just use GitHub's "draft new release" to make tarballs, which is way easier than doing them manually. |
No description provided.