Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-13163: Refactor ap_pipe to use CmdLineTask primitives #10

Merged
merged 1 commit into from Mar 22, 2018

Conversation

kfindeisen
Copy link
Member

This PR registers dataset mappings for configs and metadata persisted by ApPipeTask.

Copy link
Contributor

@r-owen r-owen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? It seems to match the entries in obs_base (other than indentation). I would have thought it could be omitted.

@kfindeisen
Copy link
Member Author

kfindeisen commented Feb 28, 2018

I was using processCcd_config and processCcd_metadata as templates; since they use full definitions, I assumed that for some reason they can't see what's in obs_base.

@kfindeisen
Copy link
Member Author

(Note that due to pipeline limitations, obs_decam is the only one I'm in any position to test at the moment.)

@r-owen
Copy link
Contributor

r-owen commented Feb 28, 2018

If obs_x can't see the defaults in obs_base then something is seriously wrong. I suggest not making these changes until you have strong evidence they are needed. You could put them on a private branch if you want to save them.

@kfindeisen
Copy link
Member Author

No, they're pretty easy to reproduce. Should the obs packages that still use PAF instead of YAML files also be able to see the obs_base defaults?

@r-owen
Copy link
Contributor

r-owen commented Mar 1, 2018

I believe obs packages that use .paf files do still use the configuration in obs_base, but I suggest asking on the DM room for details. In particular I don't know if it is allowed to just specify fields you wish to override in the .paf file.

@kfindeisen kfindeisen merged commit 8af60a5 into master Mar 22, 2018
@ktlim ktlim deleted the tickets/DM-13163 branch August 25, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants