Update obs_comCam to work with brighter-fatter processing #14
Conversation
mfisherlevine
force-pushed
the
tickets/DM-13293
branch
from
c6500b5
to
3600d08
Compare
mfisherlevine
force-pushed
the
tickets/DM-13293
branch
2 times, most recently
from
1686e0b
to
0387e5e
Compare
config/bf.py
Outdated
| config.isr.doUseOpticsTransmission = False | ||
| config.isr.doUseFilterTransmission = False | ||
| config.isr.doUseSensorTransmission = False | ||
| config.isr.doUseAtmosphereTransmission = False |
There was a problem hiding this comment.
I think the task DefaultName and thus this file name should be "measureBrighterFatter" or "measureBrighterFatterKernel".
Also, this is a lot of overrides...can these config parameters be set as defaults by the "measure brighter fatter" task itself?
There was a problem hiding this comment.
Good call on the config filename, thanks. I don't think the defaults can necessarily be set in the task itself, that seems like dangerous territory, but they are checked to be correct if the keys are present in the config dict; I hope this will suffice (and this is the same for all packages).
There was a problem hiding this comment.
I think this is going to be something we see more and more though, because calibration product generation necessarily wants to invoke some bits of isr but not others, so the default config will rarely be appropriate. I think that if this is not OK then we should leave it as-is for now, but talk about that larger issue in an appropriate place, but let's cross that bridge when we get to it.
There was a problem hiding this comment.
Having updated the filename I'll assume I'm OK to merge unless you shout.
|
I think obs_comCam is essentially dead; it'll be a part of `obs_lsst` (to be renamed from `obs_lsstCam`) once someone's had a chance to do a little work.
|
mfisherlevine
force-pushed
the
tickets/DM-13293
branch
from
0387e5e
to
cb0fd33
Compare
No description provided.