Tickets/dm 12429 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pex policies are deprecated, and should not be used here. Also they cannot read yaml, so the move requires this change.
Add docstrings where necessary, reformat others to make compliant.
r-owen
previously requested changes
Oct 27, 2017
| python: lsst.afw.image.ExposureF | ||
| storage: FitsStorage | ||
| tables: raw | ||
| template: calexp/calexp_v%(visit)d_f%(filter)s.fits |
There was a problem hiding this comment.
obs_base defines most of these data products, sometimes with fields missing that individual obs_ packages must then define -- typically just the template. I strongly suggest taking a cleanup pass to remove all duplicate information.
mfisherlevine
dismissed
r-owen’s stale review
As discussed OOB, this work is being done, but on a new ticket, along with some other cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.