Tickets/dm 12480 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version replicated a lot of things defined in obs_base. The ticket removes those redundant redefinitions, and cleans up the unnecessary paths of the path templates. Also changes some of the persisted dataset types from the deprecated decoratedImage to be exposures. Also, cleans up some unneeded refCols in the calibs.
obs_comCam only has one raft, so this is never used, so let's no longer ingest it at all (also, it's always == 'R00' anyway)
r-owen
approved these changes
Nov 10, 2017
| persistable: DecoratedImageF | ||
| python: lsst.afw.image.DecoratedImageF | ||
| persistable: ExposureF | ||
| python: lsst.afw.image.ExposureF |
There was a problem hiding this comment.
Are these entries needed for the cals? I would have expected obs_base to provide suitable defaults.
There was a problem hiding this comment.
I would expect so too, but couldn't find any. I agree, all these very standard calibration types should be moved to obs_base at some point.
| @@ -30,7 +30,6 @@ | |||
| 'date': 'text', | |||
| 'dateObs': 'text', | |||
| 'expTime': 'double', | |||
| 'raft': 'text', | |||
There was a problem hiding this comment.
I'm glad you could get rid of raft.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.